[coreboot-gerrit] Change in coreboot[master]: nb/amd/amdk8: Link raminit_f.c

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19030 )

Change subject: nb/amd/amdk8: Link raminit_f.c
......................................................................


Patch Set 9:

(1 comment)

https://review.coreboot.org/#/c/19030/9/src/southbridge/amd/sb700/early_setup.c
File src/southbridge/amd/sb700/early_setup.c:

PS9, Line 33: #if CONFIG_K8_REV_F_SUPPORT
> fam10h boards uses this file too and it needs a prototype.
I still don't see why the guards are needed. Are there any conflicts?  Is there an actual problem that this is preventing?  Are there undesirable changes to any binaries if the guards are left out of this file?


-- 
To view, visit https://review.coreboot.org/19030
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cd1ffff2c39021693fe1d5d3f90ec5f70891f57
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes