[coreboot-gerrit] Change in coreboot[master]: google/eve: Disable Deep S3 in AC mode

Duncan Laurie (Code Review) gerrit at coreboot.org
Tue Apr 11 07:16:18 CEST 2017


Duncan Laurie has uploaded a new patch set (#2). ( https://review.coreboot.org/19240 )

Change subject: google/eve: Disable Deep S3 in AC mode
......................................................................

google/eve: Disable Deep S3 in AC mode

In order to support a standard "docked" config disable Deep S3 when
connected to AC power.  This allows USB devices to wake the device
from suspend if it is externally powered, but still retains the
lower power state when running on battery.

BUG=b:36723679
BRANCH=none
TEST=manual testing on Eve for USB wake behavior:
1) when suspended on battery USB keyboard does not wake
2) when suspended while connected to AC a USB keyboard does wake
3) if suspended with AC, and then AC is removed, system does not
wake with USB keyboard
4) if suspended without AC, and then AC is added, system does not
wake with USB keyboard (it cannot get enabled without waking and
re-suspending)

Change-Id: I670e39d42cdb5b80612206da899be82ef3b2cbf2
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
M src/mainboard/google/eve/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/19240/2
-- 
To view, visit https://review.coreboot.org/19240
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I670e39d42cdb5b80612206da899be82ef3b2cbf2
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>



More information about the coreboot-gerrit mailing list