[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Update GPIO table

Marshall Dawson (Code Review) gerrit at coreboot.org
Tue Apr 11 04:41:20 CEST 2017


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19163 )

Change subject: google/kahlee: Update GPIO table
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19163/2/src/mainboard/google/kahlee/BiosCallOuts.c
File src/mainboard/google/kahlee/BiosCallOuts.c:

Line 60: 	{9, Function1, FCH_GPIO_PULL_UP_ENABLE },
> Remove, FT4 doesn't support SER_RX/TX on GPIO8/9.
For reviewers with NDA access, FT4 Functional Data Sheet doc #55350, p. 25.  System schematics should be corrected as well.


-- 
To view, visit https://review.coreboot.org/19163
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I654a8ea844dbfe71ac0d143bf29b62bba21047a5
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list