[coreboot-gerrit] Change in coreboot[master]: amd/pi/mainboards: Consolidate early duplicated code

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18434 )

Change subject: amd/pi/mainboards: Consolidate early duplicated code
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/18434/3/src/cpu/amd/pi/car.c
File src/cpu/amd/pi/car.c:

Line 26: void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
> agree
Also agree.  Not sure the history of that.  It's misleading.


Line 30: #if IS_ENABLED(CONFIG_COLLECT_TIMESTAMPS)
> need to check
As this point in the stack, timestamp_init() is removed via #define.  However, once EARLY_CBMEM_INIT, etc. is in place it's not.


Line 31: 	/* Initialize timestamp book keeping only once. */
> need to check
This comment was duplicated from another file, and is probably stale now.  The timestamp.c file implements timestamp_should_run() which checks for boot_cpu().


-- 
To view, visit https://review.coreboot.org/18434
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id10580ecc439df10df26ca99881772f328e7bdd0
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes