[coreboot-gerrit] Change in coreboot[master]: util/blobtool: Update blobtool.y

Martin Roth (Code Review) gerrit at coreboot.org
Tue Apr 11 01:04:14 CEST 2017


Hello build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19231

to look at the new patch set (#2).

Change subject: util/blobtool: Update blobtool.y
......................................................................

util/blobtool: Update blobtool.y

- Refactor the spec & setter file reads into a separate function.
- Make sure files can actually be opened before reading from them.
- Check all malloced variables.
- Set functions with no declatations as static.
- Update blobtool.tab.c_shipped to the latest version.

Change-Id: Ie97fff84493a06f48d8673d388c3882028d048ca
Signed-off-by: Martin Roth <martinroth at google.com>
---
M util/blobtool/blobtool.tab.c_shipped
M util/blobtool/blobtool.y
2 files changed, 154 insertions(+), 126 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/19231/2
-- 
To view, visit https://review.coreboot.org/19231
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie97fff84493a06f48d8673d388c3882028d048ca
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list