[coreboot-gerrit] Change in coreboot[master]: Turn CBMEM console into a ring buffer that can persist acros...
Julius Werner (Code Review)
gerrit at coreboot.org
Tue Apr 11 00:55:33 CEST 2017
Julius Werner has posted comments on this change. ( https://review.coreboot.org/18301 )
Change subject: Turn CBMEM console into a ring buffer that can persist across reboots
......................................................................
Patch Set 2:
(1 comment)
Okay, rewrote the whole thing to avoid bit fields.
Good point about SeaBIOS. I've sent the mail to their list as well, and I'll write a patch for them as soon as the general approach is approved here.
https://review.coreboot.org/#/c/18301/1/src/lib/cbmem_console.c
File src/lib/cbmem_console.c:
Line 30: * to the previous log.
> I'd call out the older messages being dropped in preference to newer ones i
Okay, updated commit message and emailed the list.
The beginning of a boot is always marked by the coreboot banner ("\n\ncoreboot-xxx <stage> starting..."), I think that's enough to find it easily.
--
To view, visit https://review.coreboot.org/18301
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbf59d58e1ad20995b98d111c4647281fbb45ff
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Kevin O'Connor <kevin at koconnor.net>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list