[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Add SERIRQ setup

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19234 )

Change subject: amd/pi/hudson: Add SERIRQ setup
......................................................................


Patch Set 1:

(4 comments)

mostly nits

https://review.coreboot.org/#/c/19234/1//COMMIT_MSG
Commit Message:

PS1, Line 9: KCONFIG
Kconfig


https://review.coreboot.org/#/c/19234/1/src/southbridge/amd/pi/hudson/Kconfig
File src/southbridge/amd/pi/hudson/Kconfig:

PS1, Line 220: If you set this option to y, the serial IRQ machine will be
             : 	  operated in continuous mode. Otherwise it is in quiet mode.
Maybe a more assertive statement, e.g. "Set this option to Y to operate serial IRQ in continuous mode..."


https://review.coreboot.org/#/c/19234/1/src/southbridge/amd/pi/hudson/lpc.c
File src/southbridge/amd/pi/hudson/lpc.c:

PS1, Line 88: (
now that we're using BIT(x) in types.h, there's no real need to use parentheses around both.


PS1, Line 89: #if !IS_ENABLED(
Change to "if (!IS_ENABLED(CONFIG..." and remove #endif.


-- 
To view, visit https://review.coreboot.org/19234
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib40a84719fcc3a5d6b3000c3c0412f1bcf629609
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes