[coreboot-gerrit] Change in coreboot[master]: driver/intel/mipi_camera: Add MIPI CSI camera SSDT generator

[V Sowmya (Code Review)]

V Sowmya has posted comments on this change. ( https://review.coreboot.org/18967 )

Change subject: driver/intel/mipi_camera: Add MIPI CSI camera SSDT generator
......................................................................


Patch Set 2:

(6 comments)

> (6 comments)

https://review.coreboot.org/#/c/18967/2/src/drivers/intel/mipi_camera/camera.c
File src/drivers/intel/mipi_camera/camera.c:

PS2, Line 4:  * Copyright 2017 Intel Corporation.
> some how (C) is missing from all our new file
Done


PS2, Line 34: dev->path.i2c.mode_10bi
> -same?
yes, this one is correct.


PS2, Line 35: I2C_SPEED_FAST,
> is this configurable ?
yes, this is configurable but for current implementation we are setting to I2C_SPEED_FAST.


PS2, Line 107: 	CHIP_NAME("Intel Camera Device")
> if we don't expect any camera device entry in future then this name is okay
According to our current design these ACPI objects should be applicable to future I2C based MIPI cameras.


https://review.coreboot.org/#/c/18967/2/src/drivers/intel/mipi_camera/chip.h
File src/drivers/intel/mipi_camera/chip.h:

PS2, Line 16: #ifndef __INTEL_MIPI_CAMERA_CHIP_H__
            : #define __INTEL_MIPI_CAMERA_CHIP_H__
> do we have a better way to define this. majority if cases we are not using 
This one can also be used.


PS2, Line 32: INTEL_ACPI_CAMERA_REGULATOR=0
> do we need this to assign?
will fix this later.


-- 
To view, visit https://review.coreboot.org/18967
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9e56d12b64081897613bf1c7abcdf915470b99
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes