[coreboot-gerrit] Change in coreboot[master]: sb/intel/i82801gx: Add i2c_block_read to smbus.h

Arthur Heymans (Code Review) gerrit at coreboot.org
Sun Apr 9 22:57:54 CEST 2017


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18927 )

Change subject: sb/intel/i82801gx: Add i2c_block_read to smbus.h
......................................................................


Patch Set 10:

(1 comment)

https://review.coreboot.org/#/c/18927/10/src/southbridge/intel/i82801gx/early_smbus.c
File src/southbridge/intel/i82801gx/early_smbus.c:

Line 85: 		;
> I know it's checkpatch but this is just ridiculous thing. Should we not hav
No opinion in this. both seem fine to me


-- 
To view, visit https://review.coreboot.org/18927
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d768a2ba128329168f26445a4fca6921c0c8642
Gerrit-PatchSet: 10
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list