[coreboot-gerrit] Change in coreboot[master]: drivers/spi/tpm: Clean up SPI TPM driver

Furquan Shaikh (Code Review) gerrit at coreboot.org
Sun Apr 9 21:46:48 CEST 2017


Hello build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19213

to look at the new patch set (#3).

Change subject: drivers/spi/tpm: Clean up SPI TPM driver
......................................................................

drivers/spi/tpm: Clean up SPI TPM driver

1. Move common TIS macros to include/tpm.h.
2. Use common TIS macros while referring to status and access registers.
3. Add a new function claim_locality to properly check for required
access bits and claim locality 0.

BUG=b:36873582

Change-Id: I11bf3e8b6e1f50b7868c9fe4394a858488367287
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/drivers/i2c/tpm/cr50.c
M src/drivers/i2c/tpm/tpm.c
M src/drivers/i2c/tpm/tpm.h
M src/drivers/spi/tpm/tpm.c
M src/include/tpm.h
5 files changed, 85 insertions(+), 80 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/19213/3
-- 
To view, visit https://review.coreboot.org/19213
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11bf3e8b6e1f50b7868c9fe4394a858488367287
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list