[coreboot-gerrit] Change in coreboot[master]: northbridge/via/cn700: Add a default VGA BIOS id
Lubomir Rintel (Code Review)
gerrit at coreboot.org
Sun Apr 9 16:08:18 CEST 2017
Lubomir Rintel has posted comments on this change. ( https://review.coreboot.org/18895 )
Change subject: northbridge/via/cn700: Add a default VGA BIOS id
......................................................................
Patch Set 5:
> Arthur's point is correct, but as he said, it's a very minor issue.
>
> Note that you can update the commit message inside gerrit without
> losing the +2. Just go to his comment and hit fix, then change the
> commit message, save and close, click done editing on the 'Files'
> line, the click 'Publish edit' at the top.
>
> Hrm. I hadn't realized the number of steps involved until I wrote
> that out.
Thank you, this is useful. I'm still struggling a bit with Gerrit and I wouldn't have figured that out myself.
--
To view, visit https://review.coreboot.org/18895
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a25ed35a5b01de6da905619fa9fce96738d1c0e
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lubomir Rintel <lkundrak at v3.sk>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Lubomir Rintel <lkundrak at v3.sk>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No
More information about the coreboot-gerrit
mailing list