[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo/x60: Add TPM 1.2 mainboard support

[Denis 'GNUtoo' Carikli (Code Review)]

Hello Stefan Reinauer, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/13410

to look at the new patch set (#3).

Change subject: mainboard/lenovo/x60: Add TPM 1.2 mainboard support
......................................................................

mainboard/lenovo/x60: Add TPM 1.2 mainboard support

This was adapted from the following commit:
  3d02b9c mainboard/lenovo/{t430s,t420s,t520,t530,x220}: Add TPM 1.2 mainboard support

Without that patch, coreboot doesn't touch the TPM, and,
in GNU/Linux, the TPM is not detected automatically.
It could still be used by running:
  modprobe tpm_tis itpm=1 force=1
which initializes it. From dmesg:
  tpm_tis tpm_tis: 1.2 TPM (device-id 0x3202, rev-id 5)
  tpm tpm0: A TPM error (38) occurred attempting to determine the timeouts
  tpm tpm0: Issuing TPM_STARTUP
  tpm tpm0: [Hardware Error]: Adjusting reported timeouts: A 10000->10000us B 10000->10000us C 0->750000us D 0->750000us

With this patch, the TPM is found detected automatically,
and we have the folliwing in dmesg:
  tpm_tis 00:07: 1.2 TPM (device-id 0x3202, rev-id 5)
  tpm tpm0: A TPM error (38) occurred attempting to determine the timeouts
  tpm tpm0: Issuing TPM_STARTUP
  tpm tpm0: [Hardware Error]: Adjusting reported timeouts: A 10000->10000us B 10000->10000us C 0->750000us D 0->750000us

Change-Id: I6e65b37507c111af1c0c56822327d5497f58f085
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
M src/drivers/pc80/tpm/tpm.c
M src/mainboard/lenovo/x60/Kconfig
M src/mainboard/lenovo/x60/devicetree.cb
3 files changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/13410/3
-- 
To view, visit https://review.coreboot.org/13410
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e65b37507c111af1c0c56822327d5497f58f085
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Denis Carikli <GNUtoo at no-log.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins)