[coreboot-gerrit] Change in coreboot[master]: nb/i945/raminit: Use common ddr2 decode functions

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18305 )

Change subject: nb/i945/raminit: Use common ddr2 decode functions
......................................................................


Patch Set 32:

(1 comment)

https://review.coreboot.org/#/c/18305/32//COMMIT_MSG
Commit Message:

PS32, Line 11: This removes computation of rank size based on columns, rows,
             : banks,... and uses the information in SPD byte 31.
             : The result of this is that dimms with multiple asymmetric ranks are
             : not supported anymore. These however are very rare and most likely
             : never tested on this platform.
> Please separate paragraphs with a blank line.
not supposed to be paragraph. fixing alignment.


-- 
To view, visit https://review.coreboot.org/18305
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97c93939d11807752797785dd88c70b43a236ee3
Gerrit-PatchSet: 32
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: coreboot org <coreboot.org at gmail.com>
Gerrit-HasComments: Yes