[coreboot-gerrit] Change in coreboot[master]: device/dram/ddr2: Don't bail out on invalid SPD checksum

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19182 )

Change subject: device/dram/ddr2: Don't bail out on invalid SPD checksum
......................................................................


Patch Set 2:

Ok, I guess the SPDs used in chromebooks don't have the checksum, since they get values updated without updating a checksum field.

Personally, I still think it's better to use the checksum, but I won't stand in the way if others think it's useless.

Maybe keep it for real DIMMs and skip it for coreboot included SPDs? Otherwise let's just get rid of the whole section that calculates the checksum.  Getting an error in the log for something that we're ignoring is just going to generate confusion.

-- 
To view, visit https://review.coreboot.org/19182
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I752d2ba6af667f26da5869aa803f7adb4d2ec211
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No