[coreboot-gerrit] Change in coreboot[master]: nb/amd/amdk8: Link raminit_f.c

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19030 )

Change subject: nb/amd/amdk8: Link raminit_f.c
......................................................................


Patch Set 9:

(3 comments)

https://review.coreboot.org/#/c/19030/9/src/mainboard/asus/a8v-e_deluxe/romstage.c
File src/mainboard/asus/a8v-e_deluxe/romstage.c:

PS9, Line 41:  /* After vt8237r/early_smbus.c! */
> Should this be removed too? And in the next few files...
yes probably.


https://review.coreboot.org/#/c/19030/9/src/northbridge/amd/amdk8/debug.h
File src/northbridge/amd/amdk8/debug.h:

PS9, Line 4: Copyright (C) 2016 Damien Zammit <damien at zamaudio.com>
> Why Damien's copyright?
wups boiler plate copied from fam10h


https://review.coreboot.org/#/c/19030/9/src/southbridge/amd/sb700/early_setup.c
File src/southbridge/amd/sb700/early_setup.c:

PS9, Line 33: #if CONFIG_K8_REV_F_SUPPORT
> #if IS_ENABLED(CONFIG_K8_REV_F_SUPPORT)
I moved prototypes from sb700.h to f.h. Maybe #if IS_ENABLED(CONFIG_SB700) #include sb700.h can be used in the relevant raminit file?

Would that be better?


-- 
To view, visit https://review.coreboot.org/19030
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cd1ffff2c39021693fe1d5d3f90ec5f70891f57
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes