[coreboot-gerrit] Change in coreboot[master]: device/dram/ddr2: Don't bail out on invalid SPD checksum

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19182 )

Change subject: device/dram/ddr2: Don't bail out on invalid SPD checksum
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/19182/1//COMMIT_MSG
Commit Message:

PS1, Line 12: fake one is created
I don't get the idea of a fake checksum.  Either it's checksummed, or it isn't.  I'd vote for leaving it in and just generating the checksum for the array.  That's what we've been doing up to this point.  Leaving it out just seems lazy.


-- 
To view, visit https://review.coreboot.org/19182
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I752d2ba6af667f26da5869aa803f7adb4d2ec211
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes