[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Enable ChromeEC

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19166 )

Change subject: google/kahlee: Enable ChromeEC
......................................................................


Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/19166/2/src/mainboard/google/kahlee/Kconfig
File src/mainboard/google/kahlee/Kconfig:

PS2, Line 29: select DRIVERS_PS2_KEYBOARD
> This isn't selected on most other chromeec systems.  Why does it need to be
I think it was the reference we used. We can remove it.


https://review.coreboot.org/#/c/19166/2/src/mainboard/google/kahlee/chromeos.c
File src/mainboard/google/kahlee/chromeos.c:

Line 45: 	mainboard_ec_init();
> Why is this sitting in chromeos.c?
doh, moved.


https://review.coreboot.org/#/c/19166/2/src/mainboard/google/kahlee/ec.c
File src/mainboard/google/kahlee/ec.c:

PS2, Line 52: #ifdef __PRE_RAM__
> Why is code being guarded by macros?
the lpc_wideio function is only in romstage. I guess it could be moved to both stages.


PS2, Line 65: u3
> Why are types being mixed? And why is the cast necessary? Is the compiler c
yes, compiler complaining.


-- 
To view, visit https://review.coreboot.org/19166
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac06b659e5274be2d7c3b34534e05adad3e3eb3d
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes