[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Add ChromeOS SMBIOS Board ID

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19167 )

Change subject: google/kahlee: Add ChromeOS SMBIOS Board ID
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19167/2/src/mainboard/google/kahlee/boardid.c
File src/mainboard/google/kahlee/boardid.c:

Line 31: 		     gpio_get(GPIO_144) << 2;
> gpio_base2_value() will do this for you. But i guess soc/ includes dont' wo
I looked at the gpio lib, but ran into problems with the soc/ inclusion, so I didn't continue down that path. I'd like to move to the soc/ dir and have started to look at that too.  I'll see if I can use it without the soc/.


-- 
To view, visit https://review.coreboot.org/19167
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dbca5b377bf79bfc91e94806956cc84caa8135f
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes