[coreboot-gerrit] Change in coreboot[master]: amd/pi/stoney: Add memmap file

Marshall Dawson (Code Review) gerrit at coreboot.org
Sat Apr 8 00:12:52 CEST 2017


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18428 )

Change subject: amd/pi/stoney: Add memmap file
......................................................................


Patch Set 6:

(1 comment)

Last version of this patch was cut/paste, but some of the other comments are now OBE after combining with https://review.coreboot.org/#/c/19083/2

https://review.coreboot.org/#/c/18428/6/src/northbridge/amd/pi/00670F00/memmap.c
File src/northbridge/amd/pi/00670F00/memmap.c:

PS6, Line 23: TOM/TOM2 for the C6 storage
> Is it always at the end where its cleaved off?
Yes


-- 
To view, visit https://review.coreboot.org/18428
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ddaa8359536081752fb8e47e49f4d5958416620
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list