[coreboot-gerrit] Change in coreboot[master]: google/fizz: Configure Memory

Shelley Chen (Code Review) gerrit at coreboot.org
Fri Apr 7 22:40:43 CEST 2017


Shelley Chen has posted comments on this change. ( https://review.coreboot.org/19205 )

Change subject: google/fizz: Configure Memory
......................................................................


Patch Set 1:

(1 comment)

patch 2 removes all this code, so these errors/warning should go away.

https://review.coreboot.org/#/c/19205/1//COMMIT_MSG
Commit Message:

Line 11: 
> What’s the effect of this patch? Does the system boot now (and didn’t befor
We are prepping for fizz bringup now, so we don't have hardware just yet.  But, previously we didn't configure the memory, so the board wouldn't have booted up and hopefully will now.


-- 
To view, visit https://review.coreboot.org/19205
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I191cc6bf1fd8aa461855c538b48fd39e3ffd7848
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list