[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge/raminit: Fix normalize_training

Patrick Rudolph (Code Review) gerrit at coreboot.org
Fri Apr 7 21:05:43 CEST 2017


Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/17610 )

Change subject: nb/intel/sandybridge/raminit: Fix normalize_training
......................................................................


Patch Set 6:

Please feel free to test it on other systems as well. The code was here for review for more than 5 month.

The code tries to find the maximum io-delay per rank, as all register modified, are rank registers. Writing the maximum io-delay of previous ranks is a mistake and is getting worse the more ranks/channels are in use.

-- 
To view, visit https://review.coreboot.org/17610
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I899db907cd2d2197fd81eda4c4656fb1e570c18f
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list