[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Set sdcard card detect (CD) host owner...

[Venkateswarlu V Vinjamuri (Code Review)]

Venkateswarlu V Vinjamuri has posted comments on this change. ( https://review.coreboot.org/18947 )

Change subject: soc/intel/apollolake: Set sdcard card detect (CD) host ownership
......................................................................


Patch Set 8:

(5 comments)

https://review.coreboot.org/#/c/18947/8/src/soc/intel/apollolake/acpi/globalnvs.asl
File src/soc/intel/apollolake/acpi/globalnvs.asl:

PS8, Line 43:  Offset of SD_CD in HOSTSW_REG
> comment is wrong
Done


https://review.coreboot.org/#/c/18947/8/src/soc/intel/apollolake/acpi/gpiolib.asl
File src/soc/intel/apollolake/acpi/gpiolib.asl:

PS8, Line 92: \SCDH
> This Method is supposed to be generic. It should not be only performing the
Done


Line 107: 		Store (CHSA (\SCDH), Local1)
> Same comment as above, but this one needs 3 arguments.
Done


https://review.coreboot.org/#/c/18947/8/src/soc/intel/apollolake/acpi/scs.asl
File src/soc/intel/apollolake/acpi/scs.asl:

Line 133: 				\_SB.SHO (\SCDP, Local0)
> See my other comments. The SHO needs another argument which is SCDH (though
Sorry about not making functions generic.


https://review.coreboot.org/#/c/18947/8/src/soc/intel/apollolake/include/soc/nvs.h
File src/soc/intel/apollolake/include/soc/nvs.h:

PS8, Line 43: Offset of SD_CD in HOSTSW_REG *
> This comment is wrong.
Done


-- 
To view, visit https://review.coreboot.org/18947
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I042a8762dc1f9cb73e6a24c1e7169c9746b2ee14
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar at intel.com>
Gerrit-Reviewer: Venkateswarlu V Vinjamuri <venkateswarlu.v.vinjamuri at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes