[coreboot-gerrit] Change in coreboot[master]: intel/apollolake: Switch FADT to ACPI version 3.0

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/19146 )

Change subject: intel/apollolake: Switch FADT to ACPI version 3.0
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19146/2//COMMIT_MSG
Commit Message:

Line 16: needs to be added to FADT structure.
> Maybe we should just add the 2 fields? And adjust the size based on version
I had that thought already. Currently only Apollo Lake and Skylake uses ACPI V5.0, the rest of the tree runs with ACPI 3.0. My doubt is that switching the complete structure to V5.0 can cause hidden issues on other boards as in this case the FADT structure would be changed and hence the length would not match with V3.0 any more.

How do you think about it, Aaron?


-- 
To view, visit https://review.coreboot.org/19146
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51c7a7a84d10283f5c2a8a2c57257d53bbdee7ed
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Prabal Saha <coolstarorganization at gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes