[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge/raminit: Always run quick_ram_check

Martin Roth (Code Review) gerrit at coreboot.org
Fri Apr 7 19:59:34 CEST 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/17615 )

Change subject: nb/intel/sandybridge/raminit: Always run quick_ram_check
......................................................................


nb/intel/sandybridge/raminit: Always run quick_ram_check

quick_ram_check doesn't change contents of memory.
Run it in S3 resume, too.

Change-Id: Icaf3650fadbb3bb87d8c780a9e79737c3cf7eb06
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
Reviewed-on: https://review.coreboot.org/17615
Tested-by: build bot (Jenkins)
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
---
M src/northbridge/intel/sandybridge/raminit.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Philippe Mathieu-Daudé: Looks good to me, but someone else must approve
  Arthur Heymans: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c
index 2bb43ce..4b92d18 100644
--- a/src/northbridge/intel/sandybridge/raminit.c
+++ b/src/northbridge/intel/sandybridge/raminit.c
@@ -436,8 +436,8 @@
 	/* Zone config */
 	dram_zones(&ctrl, 0);
 
-	if (!fast_boot)
-		quick_ram_check();
+	/* Non intrusive, fast ram check */
+	quick_ram_check();
 
 	intel_early_me_status();
 	intel_early_me_init_done(ME_INIT_STATUS_SUCCESS);

-- 
To view, visit https://review.coreboot.org/17615
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icaf3650fadbb3bb87d8c780a9e79737c3cf7eb06
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list