[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Enable ChromeEC
Martin Roth (Code Review)
gerrit at coreboot.org
Fri Apr 7 19:52:26 CEST 2017
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19166 )
Change subject: google/kahlee: Enable ChromeEC
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/19166/2/src/mainboard/google/kahlee/Kconfig
File src/mainboard/google/kahlee/Kconfig:
PS2, Line 29: select DRIVERS_PS2_KEYBOARD
This isn't selected on most other chromeec systems. Why does it need to be forcibly enabled in coreboot instead of leaving it to the payload?
--
To view, visit https://review.coreboot.org/19166
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac06b659e5274be2d7c3b34534e05adad3e3eb3d
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list