[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Add ChromeOS options

Martin Roth (Code Review) gerrit at coreboot.org
Fri Apr 7 19:50:54 CEST 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/19164 )

Change subject: google/kahlee: Add ChromeOS options
......................................................................


Patch Set 1:

(1 comment)

merge with 19166 which makes significant changes to chromeos.c?

https://review.coreboot.org/#/c/19164/1/src/mainboard/google/kahlee/Kconfig
File src/mainboard/google/kahlee/Kconfig:

PS1, Line 61: default 0x00210000 if CHROMEOS
Maybe add some help after this explaining why.


-- 
To view, visit https://review.coreboot.org/19164
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e442f5f880813e86dfd4918ecbed3eaa381f6cb
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list