[coreboot-gerrit] Change in coreboot[master]: drivers/spi: Get rid of spi_get_config

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19203 )

Change subject: drivers/spi: Get rid of spi_get_config
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/19203/2/src/drivers/spi/acpi/acpi.c
File src/drivers/spi/acpi/acpi.c:

PS2, Line 79: cs
> lets get rid of this
Done


PS2, Line 81: cs
> dev->path.spi.cs
Done


PS2, Line 98: bus
> remove bus variable. it's not used aside from the errory check which you ca
Yeah. bus was actually just meant to be used to get spi_slave structure. But since we got rid of that, we wouldn't need call to spi_acpi_get_bus here.


-- 
To view, visit https://review.coreboot.org/19203
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied38e2670784ee3317bb12e542666c224bd9e819
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes