[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Add GPIO get function

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19159 )

Change subject: amd/pi/hudson: Add GPIO get function
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/19159/1/src/southbridge/amd/pi/hudson/Makefile.inc
File src/southbridge/amd/pi/hudson/Makefile.inc:

PS1, Line 42: ramstage-y
Since the GPIO pin addresses are only defined if CONFIG_SOUTHBRIDGE_AMD_PI_KERN is enabled, should this be changed to

 ramstage-$(CONFIG_SOUTHBRIDGE_AMD_PI_KERN) += gpio.c


https://review.coreboot.org/#/c/19159/1/src/southbridge/amd/pi/hudson/gpio.c
File src/southbridge/amd/pi/hudson/gpio.c:

Line 23: 
Do some validation of the address?

 if (gpio_num < GPIO_0 || gpio_num > GPIO_148)
    die ("Error: Invalid GPIO address.\n");


-- 
To view, visit https://review.coreboot.org/19159
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f681865715ab947b525320a6f9fc63af1334b59
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes