[coreboot-gerrit] Change in coreboot[master]: pi/hudson: Add LPC IO decode enable function

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19160 )

Change subject: pi/hudson: Add LPC IO decode enable function
......................................................................


Patch Set 1:

(5 comments)

https://review.coreboot.org/#/c/19160/1//COMMIT_MSG
Commit Message:

PS1, Line 10: wither
either


https://review.coreboot.org/#/c/19160/1/src/southbridge/amd/pi/hudson/early_setup.c
File src/southbridge/amd/pi/hudson/early_setup.c:

PS1, Line 168: port
Validate port before using it to access the array?  Coverity will definitely complain about this.

 if (port >= sizeof(alt_wideio_enable)/sizeof(alt_wideio_enable[0]))
    die("Error: specified port is invalid.)


PS1, Line 184: assert
By default, assert just prints a warning message to the log if it fails.  Is that what you want?


PS1, Line 204: assert(0);
Maybe print something more useful?

  printk(BIOS_WARNING, "Error: All WIDEIO locations already used\n");


https://review.coreboot.org/#/c/19160/1/src/southbridge/amd/pi/hudson/hudson.h
File src/southbridge/amd/pi/hudson/hudson.h:

PS1, Line 90: #define   LPC_WIDEIO2_ENABLE	BIT(25)
            : #define   LPC_WIDEIO1_ENABLE	BIT(24)
            : #define   LPC_WIDEIO0_ENABLE	BIT(2)
            : 
            : #define LPC_WIDEIO_GENERIC_PORT	0x64
Align?  I can't tell if this is just a gerrit formatting issue.


-- 
To view, visit https://review.coreboot.org/19160
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bed3a99180188101e00b4431d634227e488cbda
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes