[coreboot-gerrit] Change in coreboot[master]: drivers/spi: Get rid of spi_get_config

Furquan Shaikh (Code Review) gerrit at coreboot.org
Fri Apr 7 18:05:45 CEST 2017


Hello build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19203

to look at the new patch set (#2).

Change subject: drivers/spi: Get rid of spi_get_config
......................................................................

drivers/spi: Get rid of spi_get_config

There is only one user for spi_get_config i.e. SPI ACPI. Also, the
values provided by spi_get_config are constant for now. Thus, get rid
of the spi_get_config call and fill in these constant values in SPI
ACPI code itself. If there is a need in the future to change these,
appropriate device-tree configs can be added.

BUG=b:36873582

Change-Id: Ied38e2670784ee3317bb12e542666c224bd9e819
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/drivers/spi/acpi/acpi.c
M src/drivers/spi/spi-generic.c
M src/include/spi-generic.h
M src/soc/intel/common/block/gspi/gspi.c
4 files changed, 5 insertions(+), 53 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/19203/2
-- 
To view, visit https://review.coreboot.org/19203
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied38e2670784ee3317bb12e542666c224bd9e819
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list