[coreboot-gerrit] Change in coreboot[master]: drivers/spi/acpi: Do not perform spi_setup in acpi path

Furquan Shaikh (Code Review) gerrit at coreboot.org
Fri Apr 7 16:28:00 CEST 2017


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19203 )

Change subject: drivers/spi/acpi: Do not perform spi_setup in acpi path
......................................................................


Patch Set 1:

> You need to assign a bus speed in devicetree for eve.

It's not just bus speed. There are more spi bus parameters -- clk polarity, clk phase, cs polarity. Right now we are just using the default, but SoC can override those.

-- 
To view, visit https://review.coreboot.org/19203
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied38e2670784ee3317bb12e542666c224bd9e819
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list