[coreboot-gerrit] Change in coreboot[master]: drivers/spi/acpi: Do not perform spi_setup in acpi path

Furquan Shaikh (Code Review) gerrit at coreboot.org
Fri Apr 7 16:15:04 CEST 2017


Furquan Shaikh has uploaded a new change for review. ( https://review.coreboot.org/19203 )

Change subject: drivers/spi/acpi: Do not perform spi_setup in acpi path
......................................................................

drivers/spi/acpi: Do not perform spi_setup in acpi path

SPI ACPI path does not actually perform any spi transactions. Thus,
there is no need to run a spi_setup.

BUG=b:36873582

Change-Id: Ied38e2670784ee3317bb12e542666c224bd9e819
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/drivers/spi/acpi/acpi.c
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/19203/1

diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c
index 028a37c..951ffbd 100644
--- a/src/drivers/spi/acpi/acpi.c
+++ b/src/drivers/spi/acpi/acpi.c
@@ -104,12 +104,6 @@
 		return;
 	}
 
-	if (spi_setup_slave(bus, cs, &slave)) {
-		printk(BIOS_ERR, "%s: ERROR: SPI setup failed.\n",
-			dev_path(dev));
-		return;
-	}
-
 	if (spi_get_config(&slave, &spi_cfg)) {
 		printk(BIOS_ERR, "%s: ERROR: SPI get config failed.\n",
 			dev_path(dev));

-- 
To view, visit https://review.coreboot.org/19203
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied38e2670784ee3317bb12e542666c224bd9e819
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>



More information about the coreboot-gerrit mailing list