[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Use LPSS common library

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19154 )

Change subject: soc/intel/apollolake: Use LPSS common library
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19154/1/src/soc/intel/apollolake/uart_early.c
File src/soc/intel/apollolake/uart_early.c:

PS1, Line 44: 
> make this 'base' and put it on the same line now.
Done.


Line 53: 	 * Set M and N divisor inputs and enable clock. These values
> Why was the rest of the comment dropped about the actual clock fed in? I'd 
Ok.Added the comment back.Please review.


-- 
To view, visit https://review.coreboot.org/19154
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75f9aebd60290fbf22684f8cc2ce8e8a4a4304b0
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes