[coreboot-gerrit] Change in coreboot[master]: apollolake: Switch FADT to ACPI version 3.0

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/19146 )

Change subject: apollolake: Switch FADT to ACPI version 3.0
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19146/1//COMMIT_MSG
Commit Message:

Line 15: match the specification.
> So what is missing? The sleep control and status register? minor version? I
If I dump the FADT using acpidump and disassemble them using iasl, I will get the following warning:
"// ACPI Warning: FADT revision 5 does not match length: found F4 expected 10C"

This warning is there because in our current FADT structure (in src/arch/x86/include/arch/acpi.h struct acpi_fadt) two members are missing to be ACPI5.0 compliant:
- struct acpi_gen_regaddr sleep_ctl;
- struct acpi_gen_regaddr sleep_stat;

The wired thing about this violation is Windows 10 which just ends up in a dead loop with no error/status message.
It was coolstar who pointed me to this ACPI version issue.


-- 
To view, visit https://review.coreboot.org/19146
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51c7a7a84d10283f5c2a8a2c57257d53bbdee7ed
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Prabal Saha <coolstarorganization at gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes