[coreboot-gerrit] Change in coreboot[master]: AGESA: Introduce AGESA_LEGACY_WRAPPER and its counterpart

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18628 )

Change subject: AGESA: Introduce AGESA_LEGACY_WRAPPER and its counterpart
......................................................................


Patch Set 9:

(5 comments)

https://review.coreboot.org/#/c/18628/9/src/northbridge/amd/agesa/family12/state_machine.c
File src/northbridge/amd/agesa/family12/state_machine.c:

Line 89: 
nit: extra line


https://review.coreboot.org/#/c/18628/9/src/northbridge/amd/agesa/family14/northbridge.c
File src/northbridge/amd/agesa/family14/northbridge.c:

PS9, Line 38: #if CONFIG_AMD_SB_CIMX
does this relate to this change?

IS_ENABLED()


https://review.coreboot.org/#/c/18628/9/src/northbridge/amd/agesa/family14/state_machine.c
File src/northbridge/amd/agesa/family14/state_machine.c:

PS9, Line 58: #if 0
For debug?


https://review.coreboot.org/#/c/18628/9/src/northbridge/amd/agesa/family15/state_machine.c
File src/northbridge/amd/agesa/family15/state_machine.c:

Line 81
same - extra line.


https://review.coreboot.org/#/c/18628/9/src/northbridge/amd/agesa/state_machine.h
File src/northbridge/amd/agesa/state_machine.h:

Line 27: 
extra line


-- 
To view, visit https://review.coreboot.org/18628
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3d7f8b0354e9f02c2625576f36fe06b05eb4ce
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes