[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Start Kahlee mainboard

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19161 )

Change subject: google/kahlee: Start Kahlee mainboard
......................................................................


Patch Set 1:

(4 comments)

Just to note that this is based on the amd/gardenia after the change in https://review.coreboot.org/#/c/18495

https://review.coreboot.org/#/c/19161/1/src/mainboard/google/kahlee/BiosCallOuts.c
File src/mainboard/google/kahlee/BiosCallOuts.c:

PS1, Line 135: const PSO_ENTRY DDR4PlatformMemoryConfiguration[] = {
             : 	DRAM_TECHNOLOGY(ANY_SOCKET, DDR4_TECHNOLOGY),
             : 	NUMBER_OF_DIMMS_SUPPORTED (ANY_SOCKET, ANY_CHANNEL, 2),
             : 	NUMBER_OF_CHANNELS_SUPPORTED (ANY_SOCKET, 2),
             : 	MOTHER_BOARD_LAYERS (LAYERS_6),
             : 	MEMCLK_DIS_MAP (ANY_SOCKET, ANY_CHANNEL, 0xff, 0xff, 0xff, 0xff, 0x00, 0x00, 0x00, 0x00),
             : 	CKE_TRI_MAP (ANY_SOCKET, ANY_CHANNEL, 0xff, 0xff, 0xff, 0xff),
             : 	ODT_TRI_MAP (ANY_SOCKET, ANY_CHANNEL, 0xff, 0xff, 0xff, 0xff),
             : 	CS_TRI_MAP (ANY_SOCKET, ANY_CHANNEL, 0xff, 0xff, 0xff, 0xff, 0x00, 0x00, 0x00, 0x00),
             : 	PSO_END
             : };
This has been moved to OemCustomize.c in gardenia since it was copied.  This can be updated in a follow-on patch


https://review.coreboot.org/#/c/19161/1/src/mainboard/google/kahlee/devicetree.cb
File src/mainboard/google/kahlee/devicetree.cb:

PS1, Line 46: 						device i2c 50 on end
            : 					end
            : 					chip drivers/generic/generic # dimm 0-0-1
Added to Gardenia's code?  Move to another patch?


PS1, Line 64: 0xA0, 0xA2
order changed from Gardenia?  Move to another patch?


https://review.coreboot.org/#/c/19161/1/src/mainboard/google/kahlee/romstage.c
File src/mainboard/google/kahlee/romstage.c:

PS1, Line 20: romstage_common();
I commented in https://review.coreboot.org/#/c/18495 that I didn't think this made sense.


-- 
To view, visit https://review.coreboot.org/19161
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcfe100a5e303ccf89f973d9740075bd40ff3f18
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes