[coreboot-gerrit] Change in coreboot[master]: device/dram/ddr2: Don't bail out on invalid SPD checksum

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19182 )

Change subject: device/dram/ddr2: Don't bail out on invalid SPD checksum
......................................................................

device/dram/ddr2: Don't bail out on invalid SPD checksum

One might want to pass an SPD data array with only bytes needed to
configure the memory controller (to speed up raminit). Such an
incomplete array will most likely have an invalid checksum (unless a
fake one is created).

Change-Id: I752d2ba6af667f26da5869aa803f7adb4d2ec211
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/device/dram/ddr2.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/19182/1

diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c
index 1471ed5..8d4127d 100644
--- a/src/device/dram/ddr2.c
+++ b/src/device/dram/ddr2.c
@@ -304,7 +304,7 @@
 	if (spd_ddr2_calc_checksum(spd, spd_size) != spd[63]) {
 		printram("ERROR: SPD checksum error\n");
 		dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED;
-		return SPD_STATUS_CRC_ERROR;
+		ret = SPD_STATUS_CRC_ERROR;
 	}
 
 	reg8 = spd[62];

-- 
To view, visit https://review.coreboot.org/19182
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I752d2ba6af667f26da5869aa803f7adb4d2ec211
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>