[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Use common PCR module

[Bora Guvendik (Code Review)]

Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/18673 )

Change subject: soc/intel/apollolake: Use common PCR module
......................................................................


Patch Set 18:

(3 comments)

https://review.coreboot.org/#/c/18673/17/src/soc/intel/apollolake/acpi/gpio.asl
File src/soc/intel/apollolake/acpi/gpio.asl:

PS17, Line 74: PC
> you changed scs.asl to use the PORT_SHIFT macro. Why not here?
Done


https://review.coreboot.org/#/c/18673/17/src/soc/intel/apollolake/itss.c
File src/soc/intel/apollolake/itss.c:

Line 41: }
> same line?
Done


Line 118: 
> same line
Done


-- 
To view, visit https://review.coreboot.org/18673
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacbf58dbd55bf3915676d875fcb484362d357a44
Gerrit-PatchSet: 18
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes