[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Use common PCR module

Bora Guvendik (Code Review) gerrit at coreboot.org
Thu Apr 6 23:14:00 CEST 2017


Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/18674 )

Change subject: soc/intel/skylake: Use common PCR module
......................................................................


Patch Set 18:

(5 comments)

https://review.coreboot.org/#/c/18674/17/src/soc/intel/skylake/bootblock/pch.c
File src/soc/intel/skylake/bootblock/pch.c:

Line 160: 					pch_interrupt_routing[index]);
> This can fit on the line above
Done


Line 242: 	/* Program TCO timer halt */
> same line?
Done


https://review.coreboot.org/#/c/18674/17/src/soc/intel/skylake/bootblock/uart.c
File src/soc/intel/skylake/bootblock/uart.c:

Line 75: 
> Make the formatting better now?
Done


https://review.coreboot.org/#/c/18674/17/src/soc/intel/skylake/lpc.c
File src/soc/intel/skylake/lpc.c:

PS17, Line 164: 
> Just get rid of this define and put 1 << 2 here?
Done


Line 170: static void lpc_init(struct device *dev)
> fit on same line?
Done


-- 
To view, visit https://review.coreboot.org/18674
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9336883514298e7f93fbc95aef8228202aa6fb9
Gerrit-PatchSet: 18
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list