[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common PCR support

[Bora Guvendik (Code Review)]

Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/18669 )

Change subject: soc/intel/common/block: Add Intel common PCR support
......................................................................


Patch Set 16:

(4 comments)

https://review.coreboot.org/#/c/18669/15/src/soc/intel/common/block/pcr/Kconfig
File src/soc/intel/common/block/pcr/Kconfig:

PS15, Line 6: PCR_COMM
> This should depend on SOC_INTEL_COMMON_BLOCK_PCR
Done


PS15, Line 10: dress
> 32-bit aligned accesses for their configuration registers
Done


https://review.coreboot.org/#/c/18669/15/src/soc/intel/common/block/pcr/pcr.c
File src/soc/intel/common/block/pcr/pcr.c:

PS15, Line 28: 	if ((IS_ENABLED(CONFIG_PCR_COMMON_IOSF_1_0)) &&
             : 		(!IS_ALIGNED(offset, sizeof(uint32_t))))
             : 		reg_addr += ALIGN_DOWN(offset, sizeo
> I actually think it's fine just having IOSF_1_0. Feel free to add commentar
Done


Line 45: {
> The checks should be in pcr_read16, pcr_read8, pcr_write16, and pcr_write8.
Done


-- 
To view, visit https://review.coreboot.org/18669
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78526a86b6d10f226570c08050327557e0bb2c78
Gerrit-PatchSet: 16
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes