[coreboot-gerrit] Change in coreboot[master]: amd/pi/stoney: Change to early cbmem init

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/18433 )

Change subject: amd/pi/stoney: Change to early cbmem init
......................................................................


Patch Set 7:

> Back in 2014 when I added those comments, CAR migration was not
 > done as part of cbmem_init_hooks the way we do it today. So the
 > code may work, but I know there is a lot of magic AGESA does
 > internally aroutnd CAR and variable MTRRs. None of that is
 > documented or auditable with binaryPI:
 
So what is it that you want here?  Yes, the binaryPI isn't auditable, and that's unfortunate. If it's tested and it works, what is it exactly what needs to be fixed?

-- 
To view, visit https://review.coreboot.org/18433
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c22a15752a07eebf39530ba8549ef1f74265ec
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ronald Minnich <rminnich at google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No