[coreboot-gerrit] Change in coreboot[master]: amd/northbridge/pi: Move CBMEM_INIT to subdirectories
Martin Roth (Code Review)
gerrit at coreboot.org
Thu Apr 6 22:50:35 CEST 2017
Martin Roth has posted comments on this change. ( https://review.coreboot.org/18432 )
Change subject: amd/northbridge/pi: Move CBMEM_INIT to subdirectories
......................................................................
Patch Set 7: Code-Review+2
Kyosti, I disagree with you here. This patch doesn't change any active configuration, it's just clearing the way for other platforms.
I agree that it makes sense that CAR globals should be implemented before EARLY_CBMEM_INIT is added, but that's not what this patch does.
Please explain your objection to the contents of THIS patch.
--
To view, visit https://review.coreboot.org/18432
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I144bf34f6f4379eba6a0ae2403bbe97a7df11d8b
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No
More information about the coreboot-gerrit
mailing list