[coreboot-gerrit] Change in coreboot[master]: Documentation: Describe libgfxinit hook-up

[Youness Alaoui (Code Review)]

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19054 )

Change subject: Documentation: Describe libgfxinit hook-up
......................................................................


Patch Set 2:

(1 comment)

I didn't understand all of it, I probably will (or maybe will see issues with the doc) after I give it a try. I will send suggestions then if there is a need.
For now, I just had one comment on the doc.

https://review.coreboot.org/#/c/19054/2/Documentation/gfx/libgfxinit.md
File Documentation/gfx/libgfxinit.md:

Line 51:     gma_gfxinit(uint64_t mmio_base, uint64_t linear_fb,
I assume it returns 'void' but I'd suggest explicitly adding it to the signature.


-- 
To view, visit https://review.coreboot.org/19054
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeb53a1694193cd19b5e9aa5bee25e36a60e56bd
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes