[coreboot-gerrit] Change in coreboot[master]: mainboard/amd/gardenia: Remove S4 resume check

Martin Roth (Code Review) gerrit at coreboot.org
Thu Apr 6 22:22:35 CEST 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/18494 )

Change subject: mainboard/amd/gardenia: Remove S4 resume check
......................................................................


Patch Set 5: Code-Review+2

Kyosti, The patch that got the -2 was very different than the current version.  The statement that S4/S5 paths should be the same seems reasonable to me.  Is there any reason that this patch should still have a -2?

-- 
To view, visit https://review.coreboot.org/18494
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35e6c5f7ad1de7f51b018543d2f7ce82182f11e4
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: Zheng Bao <fishbaozi at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list