[coreboot-gerrit] Change in coreboot[master]: AMD geode: Avoid conflicting mainboard_romstage_entry() decl...

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/18769 )

Change subject: AMD geode: Avoid conflicting mainboard_romstage_entry() declaration
......................................................................


Patch Set 2:

(1 comment)

> This would only be required if following ever got approved:
 > https://review.coreboot.org/#/c/18434/6
 > 
 > Since that relies on previous works implementing (and also
 > incorrectly commenting) CAR teardown against AGESA specifications,
 > that one is likely never going to see developer approval in
 > upstream.

Please stop with the condescending tone and negative review for something that doesn't have to do with this patch.

The review you point at was sent before this other patch, https://review.coreboot.org/#/c/18615/, which caused a conflict, so we end up with this patch.

https://review.coreboot.org/#/c/18769/2/src/include/cpu/amd/car.h
File src/include/cpu/amd/car.h:

Line 6: #if IS_ENABLED(CONFIG_CPU_AMD_GEODE_LX) || IS_ENABLED(CONFIG_CPU_AMD_GEODE_GX2)
> So why is this declaration in here at all if it's specific to 2 cpus? Why i
Good point. It probably shouldn't be here since the geode structure is a little different and not as generic wrt to the entry and checking the bist, which is passed in cache_as_ram_main(). I'll move this.


-- 
To view, visit https://review.coreboot.org/18769
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc759c4c93c8dfff76f5ef9a1a985dd704cfe94
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes