[coreboot-gerrit] Change in coreboot[master]: AGESA: Move amd_initmmio() call

Marc Jones (Code Review) gerrit at coreboot.org
Thu Apr 6 20:19:30 CEST 2017


Marc Jones has posted comments on this change. ( https://review.coreboot.org/18623 )

Change subject: AGESA: Move amd_initmmio() call
......................................................................


Patch Set 7:

Sorry, I just got to this. I guess I don't see the point. This just adds another layer and moves a c call out to assembly that doesn't really need to be there. *shrug*

-- 
To view, visit https://review.coreboot.org/18623
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic044d4df7b93667fa987c29c810d0bd826af87ad
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list