[coreboot-gerrit] Change in coreboot[master]: amdfwtool: Move normal firmware 2 after fanless firmware2s

Marc Jones (Code Review) gerrit at coreboot.org
Thu Apr 6 19:10:07 CEST 2017


Marc Jones has uploaded a new change for review. ( https://review.coreboot.org/19170 )

Change subject: amdfwtool: Move normal firmware 2 after fanless firmware2s
......................................................................

amdfwtool: Move normal firmware 2 after fanless firmware2s

Move the images around in the image stitching. This addresses
an issue found with PSP firmware loading on the Google Kahlee
mainboard.

Note firmware1 must come before firmware2 in the image or
the PSP will not allow APU to execute.

Change-Id: I85963fa93d6efd707cedfbc04b92d302ad5de3b1
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M util/amdfwtool/amdfwtool.c
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/19170/1

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index 58d010c..0c1bde5 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -235,9 +235,9 @@
 	{ .type = AMD_FW_PSP_SECURED_DEBUG },
 	{ .type = AMD_FW_PSP_TRUSTLETS },
 	{ .type = AMD_FW_PSP_TRUSTLETKEY },
-	{ .type = AMD_FW_PSP_SMU_FIRMWARE2 },
 	{ .type = AMD_FW_PSP_SMU_FN_FIRMWARE },
 	{ .type = AMD_FW_PSP_SMU_FN_FIRMWARE2 },
+	{ .type = AMD_FW_PSP_SMU_FIRMWARE2 },
 	{ .type = AMD_FW_PSP_SMUSCS },
 	{ .type = AMD_PSP_FUSE_CHAIN },
 	{ .type = AMD_FW_INVALID },
@@ -255,9 +255,9 @@
 	{ .type = AMD_FW_PSP_SECURED_DEBUG },
 	{ .type = AMD_FW_PSP_TRUSTLETS },
 	{ .type = AMD_FW_PSP_TRUSTLETKEY },
-	{ .type = AMD_FW_PSP_SMU_FIRMWARE2 },
 	{ .type = AMD_FW_PSP_SMU_FN_FIRMWARE },
 	{ .type = AMD_FW_PSP_SMU_FN_FIRMWARE2 },
+	{ .type = AMD_FW_PSP_SMU_FIRMWARE2 },
 	{ .type = AMD_FW_PSP_SMUSCS },
 	{ .type = AMD_PSP_FUSE_CHAIN },
 	{ .type = AMD_FW_INVALID },

-- 
To view, visit https://review.coreboot.org/19170
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I85963fa93d6efd707cedfbc04b92d302ad5de3b1
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>



More information about the coreboot-gerrit mailing list