[coreboot-gerrit] Change in coreboot[master]: amd/cpu/pi: Add basic configuration for ChromeOS

[Marc Jones (Code Review)]

Hello Marshall Dawson,

I'd like you to do a code review.  Please visit

    https://review.coreboot.org/19158

to review the following change.


Change subject: amd/cpu/pi: Add basic configuration for ChromeOS
......................................................................

amd/cpu/pi: Add basic configuration for ChromeOS

Select typical x86 items for binaryPI builds targeting ChromeOS.

Change-Id: Id9690e03e546ab821eb822da6a7c8672ed659a66
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/cpu/amd/pi/Kconfig
M src/cpu/amd/pi/Makefile.inc
2 files changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/19158/1

diff --git a/src/cpu/amd/pi/Kconfig b/src/cpu/amd/pi/Kconfig
index 91363c5..23dd3a8 100644
--- a/src/cpu/amd/pi/Kconfig
+++ b/src/cpu/amd/pi/Kconfig
@@ -67,6 +67,11 @@
 	int
 	default 32768
 
+config CHROMEOS
+	select AMDFW_OUTSIDE_CBFS
+	select VBOOT_SEPARATE_VERSTAGE
+	select VBOOT_STARTS_IN_BOOTBLOCK
+	select VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT
 endif # CPU_AMD_PI
 
 source src/cpu/amd/pi/00630F01/Kconfig
diff --git a/src/cpu/amd/pi/Makefile.inc b/src/cpu/amd/pi/Makefile.inc
index 3e82358..c5aa62b 100644
--- a/src/cpu/amd/pi/Makefile.inc
+++ b/src/cpu/amd/pi/Makefile.inc
@@ -23,7 +23,7 @@
 verstage-y += car.c
 
 romstage-y += car.c
-romstage-$(CONFIG_SEPARATE_VERSTAGE) += romstage_after_verstage.S
+romstage-$(CONFIG_VBOOT_SEPARATE_VERSTAGE) += romstage_after_verstage.S
 
 ramstage-$(CONFIG_SPI_FLASH) += spi.c
 

-- 
To view, visit https://review.coreboot.org/19158
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9690e03e546ab821eb822da6a7c8672ed659a66
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>