[coreboot-gerrit] Change in coreboot[master]: util/lint: Give better warning for help spacing issue

[Martin Roth (Code Review)]

Martin Roth has uploaded a new change for review. ( https://review.coreboot.org/19155 )

Change subject: util/lint: Give better warning for help spacing issue
......................................................................

util/lint: Give better warning for help spacing issue

Because the help block uses significant whitespace to determine whether
or not text is inside the help block, a mixture of spaces and tabs
confuses the parser.
If there's an unrecognized line, and the previous line was inside a help
block, it's likely that this line is too.

Additionally, this was found with a line that started '  configuration',
and threw a perl warning about an uninitialized value because the parser
thought this was the start of a new config line, but couldn't find the
symbol.  Now we make sure that config statements have whitespace after
the 'config' statement.

Change-Id: I46375738a18903b266ea9fff3102a1a91235e609
Signed-off-by: Martin Roth <gaumless at gmail.com>
---
M util/lint/kconfig_lint
1 file changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/19155/1

diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index c9ccfb9..9597dbb 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -520,6 +520,7 @@
         my $line_no  = $parseline[0]{file_line_no};
 
         #handle help - help text: "help" or "---help---"
+        my $lastline_was_help = $inside_help;
         $inside_help = handle_help( $line, $inside_help, $inside_config, $inside_choice, $filename, $line_no );
         $parseline[0]{inside_help} = $inside_help;
 
@@ -535,7 +536,7 @@
         }
 
         #handle config
-        elsif ( $line =~ /^\s*config/ ) {
+        elsif ( $line =~ /^\s*config\s+/ ) {
             $line =~ /^\s*config\s+([^"\s]+)\s*(?>#.*)?$/;
             my $symbol = $1;
             $inside_config = $symbol;
@@ -710,7 +711,12 @@
             # do nothing
         }
         else {
-            show_error("$line  ($filename:$line_no unrecognized)");
+            if ($lastline_was_help) {
+                show_error("The line \"$line\"  ($filename:$line_no) wasn't recognized - supposed to be inside help?");
+            }
+            else {
+                show_error("The line \"$line\"  ($filename:$line_no) wasn't recognized");
+            }
         }
 
         if ( defined $inside_menu[0] ) {

-- 
To view, visit https://review.coreboot.org/19155
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46375738a18903b266ea9fff3102a1a91235e609
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Martin Roth <martinroth at google.com>