[coreboot-gerrit] Change in coreboot[master]: util/ectool: Fix timeout on sending EC command

Arthur Heymans (Code Review) gerrit at coreboot.org
Thu Apr 6 14:26:05 CEST 2017


Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19151 )

Change subject: util/ectool: Fix timeout on sending EC command
......................................................................

util/ectool: Fix timeout on sending EC command

When setting output to verbose it incorrectly reports that it times
out on every command.

TESTED on Thinkpad X60.

Change-Id: I24f05f0c165462d5ba2604c7e2fe139400683275
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M util/ectool/ec.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/19151/1

diff --git a/util/ectool/ec.c b/util/ectool/ec.c
index 08b6b1b..53a5360 100644
--- a/util/ectool/ec.c
+++ b/util/ectool/ec.c
@@ -70,7 +70,7 @@
 		if ((timeout & 0xff) == 0)
 			debug(".");
 	}
-	if (timeout) {
+	if (!timeout) {
 		debug("Timeout while sending data 0x%02x to EC!\n", data);
 		// return -1;
 	}

-- 
To view, visit https://review.coreboot.org/19151
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I24f05f0c165462d5ba2604c7e2fe139400683275
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>



More information about the coreboot-gerrit mailing list